-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add strict flag for assert #329
Conversation
Thank you so much @susarlanikhilesh 🎉 🎉 The tests are failing because some of our tests expect a panic to occur, and if the flag is not set (eg: the code is run via a test rather than cli) I believe viper is returning the default boolean value of |
Yes the strict flag is false, I did set when panic is true in the test cases |
I would prefer for
An easier way to do it might be to invert the name of the flag to something like |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #329 +/- ##
=======================================
Coverage 55.34% 55.35%
=======================================
Files 113 113
Lines 9885 9886 +1
=======================================
+ Hits 5471 5472 +1
Misses 4052 4052
Partials 362 362 ☔ View full report in Codecov by Sentry. |
Addresses Issue